You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Configuration Consistency Ensure that the moved configuration settings for isort, black, and docformatter in pyproject.toml are consistent with the previous settings in tox.ini and setup.cfg.
Removed Configuration Verify if the removed pytest configuration from setup.cfg is intentional and if it's been moved to an appropriate location or if it's no longer needed.
Align isort configuration with black to ensure consistent formatting
Add a line-length configuration to the [tool.isort] section to ensure it matches the line-length setting in the [tool.black] section. This will help maintain consistency between isort and black formatting.
[tool.isort]
# isort is a common python tool for keeping imports nicely formatted.
# Automatically keep imports alphabetically sorted, on single lines in
# PEP recommended sections (https://peps.python.org/pep-0008/#imports)
# files or individual lines can be ignored via `# isort:skip|# isort:skip_file`.
profile = "black"
-py_version=38+py_version = 38
force_single_line = true
+line_length = 120
Apply this suggestion
Suggestion importance[1-10]: 7
Why: Adding a line-length configuration to the [tool.isort] section to match the [tool.black] section is a valid enhancement. It ensures consistency between the two tools, which can help maintain uniform formatting across the project.
7
Enhance docformatter configuration for more consistent documentation formatting
Consider adding more configuration options to the [tool.docformatter] section, such as wrap-summaries, wrap-descriptions, and make-summary-multi-line, to ensure consistent documentation formatting across the project.
Why: The suggestion to add additional configuration options to the [tool.docformatter] section is a reasonable enhancement. It can improve documentation formatting consistency, although it is not critical to the current PR changes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Moved
isortandblacksettings from tox.ini file to pyproject.toml.Motivation and Context
isortandblacksettings can now be configured inpyproject.toml(PEP 621)Types of changes
Checklist
PR Type
enhancement, configuration changes
Description
isort,black, anddocformattersettings fromtox.iniandsetup.cfgtopyproject.toml.isort,black, anddocformatterinpyproject.toml.setup.cfgas all pytest settings are now configured inpyproject.toml.PRDescriptionHeader.CHANGES_WALKTHROUGH
pyproject.toml
Add isort, black, and docformatter configurationspy/pyproject.toml
isortconfiguration with profile set toblack.blackconfiguration with line length and target version.docformatterconfiguration with recursive option.setup.cfg
Remove redundant pytest settingspy/setup.cfg
tox.ini
Remove isort configurationpy/tox.ini
isortconfiguration.